lxd: Initialise server name and global config before storage patches are run #12421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
And then reload them after patches have run in case its been modified. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
force-pushed
the
tp-servername-patch
branch
from
4f73ea7
to
56fa98f
Compare
simondeziel
previously approved these changes
Oct 19, 2023
|
LGTM, but static analysis is not happy. |
|
@monstermunchkin thanks. Please can you take over this PR and also review the other recent patches that retrieve custom volumes to make them use the same pattern. |
…sUnsetInvalidBlockSettingsV2 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
…sUnsetInvalidBlockSettings Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
tp-servername-patch
branch
from
43d7ed2
to
942350e
Compare
monstermunchkin
approved these changes
Oct 19, 2023
|
@simondeziel please can you approve? |
simondeziel
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes start up issue for ZFS volumes from #12390